Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Generate OpenAPI 3.0 API documentation #545

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 26, 2023

This PR represents a first step towards improving our automatically generated API documentation. It includes the following changes:

  • Adds general API level doc comments that are a requirement for Swagger/OpenAPI.
  • Adds missing godocs for parameters where they were missing. This was causing Swagger validation to fail and was preventing QE from successfully converting our Swagger 2 documentation to OpenAPI 3.0
  • Fixes some incorrect parameter documentation
  • Adds a new target to convert our Swagger 2 documentation to OpenAPI 3.0 using the Swagger conversion API at converter.swagger.io.
  • Corrects the existing docs-swagger target command invocation.
  • Updates the redoc target to use the newly generated OpenAPI 3.0 documentation.

@mansam mansam changed the title Improve API documentation 📖 Improve API documentation Oct 26, 2023
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mguetta1 @sshveta for visibility.

Necessary to satisfy Swagger/OpenAPI validator.

Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
@mansam mansam force-pushed the improve-swagger-docs branch from ceb4fbb to 12b00a5 Compare October 27, 2023 15:44
@mansam mansam merged commit 4721a39 into konveyor:main Oct 27, 2023
11 of 12 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
This PR represents a first step towards improving our automatically
generated API documentation. It includes the following changes:

* Adds general API level doc comments that are a requirement for
Swagger/OpenAPI.
* Adds missing godocs for parameters where they were missing. This was
causing Swagger validation to fail and was preventing QE from
successfully converting our Swagger 2 documentation to OpenAPI 3.0
* Fixes some incorrect parameter documentation
* Adds a new target to convert our Swagger 2 documentation to OpenAPI
3.0 using the Swagger conversion API at `converter.swagger.io`.
* Corrects the existing docs-swagger target command invocation.
* Updates the redoc target to use the newly generated OpenAPI 3.0
documentation.

---------

Signed-off-by: Sam Lucidi <[email protected]>
@mansam mansam added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 9, 2023
@mansam mansam changed the title 📖 Improve API documentation 📖 Generate OpenAPI 3.0 API documentation Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants