Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update OpenAPI spec w/ Assessment changes #520

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 16, 2023

ArchivedIssue in the API package being an alias to another type confuses the swag tool. To mitigate this, I had to overwrite the swagger type of that field on the Analysis resource with object. This means that the api documentation for that field will be unhelpfully vague, but it allows the documentation to build.

@mansam mansam requested a review from jortel October 16, 2023 16:40
@mansam mansam changed the title Update OpenAPI spec w/ Assessment changes 📖 Update OpenAPI spec w/ Assessment changes Oct 16, 2023
@mansam mansam force-pushed the update-documentation branch from a6a0e92 to b2d435c Compare October 16, 2023 16:42
@jortel
Copy link
Contributor

jortel commented Oct 16, 2023

The swagger tool is really bad.
Let's investigate using a better tool. Perhaps. go-swagger.

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansam mansam merged commit b9593af into konveyor:main Oct 17, 2023
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
`ArchivedIssue` in the API package being an alias to another type
confuses the swag tool. To mitigate this, I had to overwrite the swagger
type of that field on the Analysis resource with `object`. This means
that the api documentation for that field will be unhelpfully vague, but
it allows the documentation to build.

Signed-off-by: Sam Lucidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants