Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👻 Support seed build args. #503

Merged
merged 1 commit into from
Oct 5, 2023
Merged

👻 Support seed build args. #503

merged 1 commit into from
Oct 5, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Oct 4, 2023 •
edited
Loading

Better support for test run analysis with seed PRs using
--build-arg SEED_PROJECT <url>
--build-arg SEED_BRANCH <branch>

Example:

$ docker build . -t quay.io/jortel/tackle2-hub:latest \
  --build-arg 'SEED_PROJECT=jortel/tackle2-seed' \
  --build-arg 'SEED_BRANCH=add-targets' \
  && docker push quay.io/jortel/tackle2-hub:latest

@jortel
Support seed build args.
3669d4c 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel marked this pull request as ready for review October 5, 2023 15:39
pranavgaikwad
pranavgaikwad approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement

@jortel jortel merged commit e44f340 into konveyor:main Oct 5, 2023
12 of 13 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
@jortel @aufi
👻 Support seed build args. (konveyor#503)
003362a 
Better support for test run analysis with seed PRs using 
`--build-arg SEED_PROJECT <url>`
`--build-arg SEED_BRANCH <branch> `

Example:
```
$ docker build . -t quay.io/jortel/tackle2-hub:latest \
  --build-arg 'SEED_PROJECT=jortel/tackle2-seed' \
  --build-arg 'SEED_BRANCH=add-targets' \
  && docker push quay.io/jortel/tackle2-hub:latest
```

Signed-off-by: Jeff Ortel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jortel @pranavgaikwad