Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👻 refactor migrations #497

Merged
merged 1 commit into from
Oct 3, 2023
Merged

👻 refactor migrations #497

merged 1 commit into from
Oct 3, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Sep 28, 2023 •
edited
Loading

Process:

  1. For each version(3-10):
    • Copy files from previous version unless redefined (already exists).
    • Remove the type alias (to previous version) in pkg.go.
  2. For each version(2-10):

fixes: #426

@jortel jortel changed the title Migration2 👻 refactor migrations Sep 28, 2023
@jortel jortel marked this pull request as ready for review October 3, 2023 16:46
mansam
mansam approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to be rid of the aliases.

@jortel jortel merged commit 2c86e5f into konveyor:main Oct 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansam mansam mansam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👻 Migration-models
2 participants
@jortel @mansam