🐛 Exclude virtual tags from writing/updating #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
changed the title
jortel
reviewed
Sep 29, 2023
api/application.go
Outdated
| r.WithSourcedTags(archetypeTags, "archetype") | ||
| r.WithSourcedTags(resolver.AssessmentTags(), "assessment") | ||
| r.WithVirtualTags(archetypeTags, "archetype") | ||
| r.WithVirtualTags(resolver.AssessmentTags(), "assessment") |
There was a problem hiding this comment.
Did you mean to use new the const here ^^ and below vv?
There was a problem hiding this comment.
I did, thanks for pointing that out.
jortel
reviewed
Sep 29, 2023
migration/v9/model/archetype.go
Outdated
| CriteriaTags []Tag `gorm:"many2many:ArchetypeCriteriaTags"` | ||
| Tags []Tag `gorm:"many2many:ArchetypeTags"` | ||
| CriteriaTags []Tag `gorm:"many2many:ArchetypeCriteriaTags;constraint:OnDelete:CASCADE"` | ||
| Tags []Tag `gorm:"many2many:ArchetypeTags;constraint:OnDelete:CASCADE"` |
There was a problem hiding this comment.
I assume this fixes archetype delete.
There was a problem hiding this comment.
This already exists on main so I'm not sure why it's showing up separately. I'll rebase my PR and clean it up.
jortel
approved these changes
Sep 29, 2023
* Add `virtual` field to TagRef * Ignore tag refs with `virtual` field set true when adding, updating, or replacing tags. * Fix bug preventing archetype tags being inherited properly * go fmt Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
mansam
force-pushed
the
virtual-tags
branch
from
2121315 to
2ff6621
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualfield to TagRefvirtualfield set true when adding, updating, or replacing tags.