🌱 add ticket API test #477
Conversation
Signed-off-by: Yash Khare <[email protected]>
Signed-off-by: Yash Khare <[email protected]>
| ) | ||
|
|
||
| var Samples = []api.Ticket{ | ||
| { |
There was a problem hiding this comment.
I'm not sure about typical values of the Ticket, but values of most of fields below might need be updated. Need find some example values.
test/api/ticket/api_test.go
Outdated
| assert.Must(t, Identity.Create(&identity)) | ||
|
|
||
| // create a sample tracker for the ticket. | ||
| tracker := api.Tracker{ |
There was a problem hiding this comment.
The Tracker fields might be better re-used from from Tracker API test Samples instead of writing it here as well as in List test.
There was a problem hiding this comment.
Shall i run a loop for tracker samples ?
There was a problem hiding this comment.
or shall i use only one tracker from the sample?
There was a problem hiding this comment.
One tracker from sample should be enough!
test/api/ticket/api_test.go
Outdated
| } | ||
|
|
||
| // List Tickets. | ||
| got, err := Ticket.List() |
There was a problem hiding this comment.
There two additional filters in List actions - by application and tracker - https://github.com/konveyor/tackle2-hub/blob/main/api/ticket.go#L74-L79. Maybe it is not required for simple test, but might be worth for adding those.
Signed-off-by: Yash Khare <[email protected]>
Signed-off-by: Yash Khare <[email protected]>
Signed-off-by: Yash Khare <[email protected]>
| createdTickets = append(createdTickets, r) | ||
|
|
||
| // List Tickets. | ||
| got, err := Ticket.List() |
There was a problem hiding this comment.
There is no filtering parameter (like Application or Tracker ID), the filter is on API side in List action. Unless filter parameters are sent to API, I'm not sure how the filtering is tested.
Signed-off-by: Yash Khare <[email protected]>
Add the ticket API Test --------- Signed-off-by: Yash Khare <[email protected]>
Add the ticket API Test