🐛 Fix BusinessService CSV import (#766) (#768)

CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Marek Aufart <[email protected]>
konveyor · Nov 26, 2024 · 065fd75 · 065fd75
1 parent f9d05e8
commit 065fd75
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/importer/manager.go b/importer/manager.go
@@ -166,22 +166,22 @@ func (m *Manager) createApplication(imp *model.Import) (ok bool) {
 	}
 
 	// Assign Business Service
-	businessService := &model.BusinessService{}
+	businessService := model.BusinessService{}
 	businessServices := []model.BusinessService{}
 	m.DB.Find(&businessServices)
 	normBusinessServiceName := normalizedName(imp.BusinessService)
 	// Find existing BusinessService
 	for _, bs := range businessServices {
 		if normalizedName(bs.Name) == normBusinessServiceName {
-			businessService = &bs
+			businessService = bs
 		}
 	}
 	// If not found business service in database and import specifies some non-empty business service, proceeed with create it
 	if businessService.ID == 0 && normBusinessServiceName != "" {
 		if imp.ImportSummary.CreateEntities {
 			// Create a new BusinessService if not existed
 			businessService.Name = imp.BusinessService
-			result := m.DB.Create(businessService)
+			result := m.DB.Create(&businessService)
 			if result.Error != nil {
 				imp.ErrorMessage = fmt.Sprintf("BusinessService '%s' cannot be created.", imp.BusinessService)
 				return
@@ -193,7 +193,7 @@ func (m *Manager) createApplication(imp *model.Import) (ok bool) {
 	}
 	// Assign business service to the application if was specified
 	if businessService.ID != 0 {
-		app.BusinessService = businessService
+		app.BusinessService = &businessService
 	}
 
 	// Process import Tags & TagCategories