Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 initial workflow run collect data #194

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

🌱 initial workflow run collect data #194

wants to merge 8 commits into from

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Jan 13, 2025 •
edited
Loading

initial workflow run collect data

To run workflow mode,

export GITHUB_TOKEN="your_token"
export WORKFLOW=True

run npm run collect-assets

for release mode,

export WORKFLOW=False

run npm run collect-assets

@savitharaghunathan
initial workflow run collect data
787faa7 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan savitharaghunathan requested a review from a team as a code owner January 13, 2025 22:00
@savitharaghunathan savitharaghunathan marked this pull request as draft January 13, 2025 22:00
@savitharaghunathan savitharaghunathan self-assigned this Jan 13, 2025
sjd78
sjd78 requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thought mostly because I was thinking through a bunch of things as I was reviewing. The base is solid, mostly just needs some reorganization.

scripts/_util.js Outdated Show resolved Hide resolved
scripts/_util.js Outdated Show resolved Hide resolved
scripts/_util.js Outdated Show resolved Hide resolved
scripts/_util.js Outdated Show resolved Hide resolved
scripts/collect-assets-workflow.js Outdated Show resolved Hide resolved
scripts/_download.js Outdated Show resolved Hide resolved
scripts/_download.js Outdated Show resolved Hide resolved
scripts/_download.js Outdated Show resolved Hide resolved
scripts/_download.js Show resolved Hide resolved
scripts/collect-assets-workflow.js Outdated Show resolved Hide resolved
@savitharaghunathan
adding review fedback
0907f88 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan savitharaghunathan marked this pull request as ready for review January 16, 2025 19:40
@savitharaghunathan
use env variables to select workflow/release
072719c 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan
setting exe bit
81f4c51 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan
Copy link
Member Author

issue: #198

@sjd78 sjd78 linked an issue Jan 21, 2025 that may be closed by this pull request
Update collect-assets to download kai assets from main branch / latest CI workflows #198
Open
djzager
djzager requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing I notice

scripts/collect-assets.js Outdated Show resolved Hide resolved
djzager
djzager previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Jan 21, 2025
Open
Open
Open
@savitharaghunathan
Copy link
Member Author

@sjd78 updated error handling to exit the process if there is an error. ptal

npm run collect-assets

> [email protected] collect-assets
> rimraf ./downloaded_assets && node ./scripts/collect-assets.js

working from: /Users/sraghuna/local_dev/editor-extensions
WORKFLOW environment variable is not set. Downloading GitHub release assets...
Fetching GitHub release metadata for konveyor/kai release: v0.0.5
Error during asset collection: Error in downloadGitHubRelease: Error in getGitHubReleaseMetadata: Failed to fetch release metadata: Not Found

@savitharaghunathan
update error handling
d06c02c 
Signed-off-by: Savitha Raghunathan <[email protected]>
@savitharaghunathan
Copy link
Member Author

fixes #235

@savitharaghunathan savitharaghunathan linked an issue Jan 21, 2025 that may be closed by this pull request
Update collect-assets to fail if target release tag cannot be found #235
Open
@savitharaghunathan
reset download tag to 0.0.4
29c9142 
Signed-off-by: Savitha Raghunathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rszwajko rszwajko rszwajko left review comments

@djzager djzager djzager left review comments

@sjd78 sjd78 Awaiting requested review from sjd78

Requested changes must be addressed to merge this pull request.

Assignees

@savitharaghunathan savitharaghunathan

Labels
None yet
Projects
Kai Tech Preview Release
Status: In Progress
Milestone
No milestone
4 participants
@savitharaghunathan @djzager @sjd78 @rszwajko