-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Update the shared workspace to build to esm and commonjs #193
Conversation
Signed-off-by: Ian Bolton <[email protected]>
de062c1
to
be715f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use vite library mode? https://vite.dev/guide/build#library-mode
From what I can tell, esbuild comes in from @vitejs/plugin-react
, but I could be wrong. Would be good to have the builders/packagers used all explicity listed as devDependencies in the approriate package.json files.
Probably can also remove:
editor-extensions/tsconfig.json
Lines 14 to 18 in 6bdca4c
"references": [ | |
{ "path": "./shared" }, | |
{ "path": "./vscode" }, | |
{ "path": "./webview-ui" } | |
] |
and:
editor-extensions/shared/tsconfig.json
Line 10 in 6bdca4c
"tsBuildInfoFile": "./dist/tsconfig.tsbuildinfo" |
Signed-off-by: Ian Bolton <[email protected]>
a7192df
to
82bec09
Compare
More work to: - remove the remaining typescript composite configs - enhance the vite config for shared package - fixup the dev scripts so all workspaces can have their builders running in watch mode Signed-off-by: Scott J Dickerson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a few changes basically to drop the rest of the composite project configs and to fix up the dev scripts a bit. Super easy to do on a excellent base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #192
Vite Library Mode Integration:
Summary of changes:
shared
with vite in library modeshared
build has a chance to run before the other packages go looking for its files