perf: Make index of Node readonly to prevent potential perf problem #1777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make index of Node readonly to prevent potential remove child with complexity o(n^2)
Note that Konva.Container#removeChildren function comment with these line
That means without reset the parent, Konva.Node#remove would call _setChildrenIndice which will take into extra o(n^2) complexity. It works in this case but failed in other case such as call remove node in a certain loop, which offen ocurrs in increasing draw visible node and decreasing destory invisible node in current viewport.
Thus replace the index property with readonly index is a better way to prevent the unexpected complextiy by frequent operation of a Konva Node.