284 ImageTransformations

[Sevitas]

Motivation

Fixes #284

Checklist

• Code follows coding conventions held in this repo
• Automated tests have been added
• Tests are passing
• Docs have been updated (if applicable)
• Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Check if scenario mentioned in #284 is not reproducible

[codecov]

Codecov Report

Merging #288 (c5ea204) into master (a71a7f3) will decrease coverage by 4.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   93.14%   88.28%   -4.87%     
==========================================
  Files         117      117              
  Lines        2467     2467              
  Branches      304      301       -3     
==========================================
- Hits         2298     2178     -120     
- Misses        161      167       +6     
- Partials        8      122     +114     

Impacted Files	Coverage Δ
...actions/Configuration/DefaultRetryPolicyOptions.cs	100.00% <ø> (ø)
...very.Abstractions/Configuration/DeliveryOptions.cs	100.00% <ø> (ø)
...very.Abstractions/ContentItems/ResolvingContext.cs	100.00% <ø> (ø)
....Delivery.Abstractions/DeliveryClientExtensions.cs	100.00% <ø> (ø)
...stractions/Extensions/DeliveryOptionsExtensions.cs	100.00% <ø> (ø)
Kentico.Kontent.Delivery.Caching/CacheHelpers.cs	81.53% <ø> (-14.62%)	⬇️
...co.Kontent.Delivery.Caching/DeliveryClientCache.cs	85.50% <ø> (-10.15%)	⬇️
...ontent.Delivery.Caching/DistributedCacheManager.cs	61.36% <ø> (-13.64%)	⬇️
...ico.Kontent.Delivery.Caching/MemoryCacheManager.cs	71.42% <ø> (-9.90%)	⬇️
...njection/Extensions/ServiceCollectionExtensions.cs	93.54% <ø> (-1.62%)	⬇️
... and 115 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71a7f3...c5ea204. Read the comment docs.

[petrsvihlik]

lgtm

[Simply007]

I am not sure whether we want to release major version v16 because of namespace changes, how much do you rush on this @petrsvihlik?

[petrsvihlik]

can you perhaps release a beta package? :)

[Simply007]

@Sevitas already did - https://github.com/Kentico/kontent-delivery-sdk-net/releases/tag/16.0.0.beta1

[petrsvihlik]

nope, he didn't follow semver and the artifact didn't get published: https://github.com/Kentico/kontent-delivery-sdk-net/runs/3965485811?check_suite_focus=true

16.0.0.beta1 => 16.0.0-beta1

[Simply007]

nope, he didn't follow semver and the artifact didn't get published: https://github.com/Kentico/kontent-delivery-sdk-net/runs/3965485811?check_suite_focus=true

16.0.0.beta1 => 16.0.0-beta1

Ahh - OK.

@Sevitas - could you fix that?

[Sevitas]

nope, he didn't follow semver and the artifact didn't get published: https://github.com/Kentico/kontent-delivery-sdk-net/runs/3965485811?check_suite_focus=true
16.0.0.beta1 => 16.0.0-beta1

Ahh - OK.

@Sevitas - could you fix that?

https://github.com/Kentico/kontent-delivery-sdk-net/releases/tag/16.0.0-beta1
https://www.nuget.org/packages/Kentico.Kontent.Delivery/16.0.0-beta1

[Simply007]

Closing in favor of #300