Fix nested fragment transactions crash (fix #994)

Signed-off-by: Daniele Ricci <[email protected]>
kontalk · Apr 22, 2017 · 61f9c10 · 61f9c10
1 parent a2a3444
commit 61f9c10
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/app/src/main/java/org/kontalk/ui/AbstractComposeFragment.java b/app/src/main/java/org/kontalk/ui/AbstractComposeFragment.java
@@ -1076,12 +1076,10 @@ private AudioFragment getAudioFragment() {
             FragmentActivity parent = getActivity();
             if (parent != null) {
                 fragment = new AudioFragment();
-                FragmentManager fm = parent.getSupportFragmentManager();
+                FragmentManager fm = getFragmentManager();
                 fm.beginTransaction()
                     .add(fragment, "audio")
                     .commit();
-                // commit immediately please
-                fm.executePendingTransactions();
             }
         }
 

diff --git a/app/src/main/java/org/kontalk/ui/ComposeMessage.java b/app/src/main/java/org/kontalk/ui/ComposeMessage.java
@@ -134,11 +134,10 @@ protected boolean isNormalUpNavigation() {
 
     private void setComposeFragment(@NonNull AbstractComposeFragment f) {
         mFragment = f;
-        FragmentTransaction ft = getSupportFragmentManager().beginTransaction();
-        ft.replace(R.id.fragment_compose_message, f);
-        ft.setTransition(FragmentTransaction.TRANSIT_NONE);
-        ft.commitAllowingStateLoss();
-        getSupportFragmentManager().executePendingTransactions();
+        getSupportFragmentManager().beginTransaction()
+            .replace(R.id.fragment_compose_message, f)
+            .setTransition(FragmentTransaction.TRANSIT_NONE)
+            .commitNowAllowingStateLoss();
     }
 
     @Override