housekeeping: fix catalog apps generation and validation. #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-nicholson
changed the title
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
nathan-nicholson
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doing the AWS STS work I found this function that seems to be buggy. Not only loading information into each catalog app wasn't working because it was operating on a copy of the original value, but the error message wasn't being handled at all.
The function returned 2 important values, a boolean that would say if the catalog was incorrect and an error that would say if the catalog was incorrect, thus making it
if err != nilto always have a non-trueboolreturn.If the callers were handling this in a way that would require the "bug" to be there then this would break the current flow.
Related Issue(s)
Fixes #
How to test