Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stty 1 #2219

Closed
wants to merge 8 commits into from
Closed

Fix stty 1 #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06ab85c
added bubbletea quit method instead of os exit
jokestax Jul 2, 2024
d99286e
removed os package
jokestax Jul 2, 2024
3dcf635
signed commit
jokestax Jul 2, 2024
bfa9e3b
Revert "signed commit"
jokestax Jul 2, 2024
b2656c3
Revert "Revert "signed commit""
jokestax Jul 2, 2024
a706a37
signed commit
jokestax Jul 2, 2024
f6898fe
signed
jokestax Jul 2, 2024
c990b16
minor fix
jokestax Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/k3d/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
utils "github.com/kubefirst/kubefirst-api/pkg/utils"
"github.com/kubefirst/kubefirst-api/pkg/wrappers"
"github.com/kubefirst/kubefirst/internal/catalog"
"github.com/kubefirst/kubefirst/internal/progress"
"github.com/kubefirst/kubefirst/internal/gitShim"
"github.com/kubefirst/kubefirst/internal/segment"
"github.com/kubefirst/kubefirst/internal/utilities"
Expand Down Expand Up @@ -1407,7 +1408,7 @@ func runK3d(cmd *cobra.Command, args []string) error {
reports.LocalHandoffScreenV2(viper.GetString("components.argocd.password"), clusterNameFlag, gitDestDescriptor, cGitOwner, config, ciFlag)

if ciFlag {
os.Exit(0)
progress.Progress.Quit()
}
}

Expand Down
5 changes: 2 additions & 3 deletions cmd/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ package cmd

import (
"fmt"
"os"

"github.com/kubefirst/kubefirst/internal/provisionLogs"
"github.com/kubefirst/kubefirst/internal/progress"
"github.com/nxadm/tail"
"github.com/spf13/cobra"
"github.com/spf13/viper"
Expand All @@ -28,7 +27,7 @@ var logsCmd = &cobra.Command{
t, err := tail.TailFile(viper.GetString("k1-paths.log-file"), tail.Config{Follow: true, ReOpen: true})
if err != nil {
fmt.Printf("Error tailing log file: %v\n", err)
os.Exit(1)
progress.Progress.Quit()
}

for line := range t.Lines {
Expand Down
72 changes: 0 additions & 72 deletions cmd/root.go
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion internal/k3d/menu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ import (
"os"
"strings"

"github.com/kubefirst/kubefirst/internal/progress"
"github.com/charmbracelet/bubbles/list"
tea "github.com/charmbracelet/bubbletea"
"github.com/charmbracelet/lipgloss"
)


const ListHeight = 14
const DefaultWidth = 20

Expand Down Expand Up @@ -125,7 +127,7 @@ func MongoDestinationChooser(inCluster bool) string {
model, err := tea.NewProgram(m).Run()
if err != nil {
fmt.Println("Error running program:", err)
os.Exit(1)
progress.Progress.Quit()
}

var result string
Expand Down
Loading