fix: update base domain to kubefirst.konstruct.io #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muse-sisay can you fix the branding issue (the failed workflow)? |
Vale matched the letters `konstruct` in the middle of another sentence. Eg it would match it on `https:// kubefirst.konstruct.io/docs` and give an error. This is an acceptable scenario. This commit add regex match for konstruct
|
Hey @fharper, |
|
@muse-sisay: I understand why you did that, but I didn't want a regex for the reason that we should not link on link. There should be text for the link for a better experience, so that rule is sometimes showing us mistake like this one. Let me revert and fix the README :) |
fharper
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates
docs.kubefirst.ioto `kubefirst.konstruct.io/docs'Related Issue(s)
NA
How to test