Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wording for the GitLab group prerequisite #801

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

fharper
Copy link
Contributor

@fharper fharper commented Oct 21, 2024

Also add information about the fact that the name can be whatever the user want to avoid confusion.

Also add information about the fact that the name can be whatever the user want to avoid confusion.
@fharper fharper self-assigned this Oct 21, 2024
@bil9000
Copy link

bil9000 commented Oct 21, 2024

Be as prescriptive as possible.
"You will need to create a group in gitlab with developer permissions named 'your-gitlab-group'."
Including a link to the create group in gitlab:
https://gitlab.com/groups/new#create-group-pane

@fharper
Copy link
Contributor Author

fharper commented Oct 21, 2024

How do you create a GitLab group with developer permissions? I don't see anything about permissions in the interface when I create a group, or when managing it afterwards. I think it was a text issue when we merged docs a while ago, and since most of our users are on GitHub, nobody noticed before. If it's really this permission, just need to be sure to know how to do it as I want to be sure it's clear in the docs :)

@bil9000
Copy link

bil9000 commented Oct 21, 2024

Screenshot 2024-10-21 at 3 05 24 PM

@fharper
Copy link
Contributor Author

fharper commented Oct 21, 2024

My understanding of this is that it's not permissions, but more like GitLab getting more information about who will use the group to either display a different interface or send marketing material. If I read the text right before, that's the impression I get but more than happy to be wrong.

CleanShot 2024-10-21 at 15 09 31@2x

There is also nothing in their docs on that (the permissions for each group should be defined somewhere, especially with the other group permission). It also change nothing no matter the answer I use in terms of the group created based on my tests, but I'm not a GitLab expert.

I asked @muse-sisay to help me understand this more clearly since he has a GitLab expertise that I definitely don't have.

@bil9000
Copy link

bil9000 commented Oct 21, 2024

I didn't write the original docs, I'm just trying to decode them.

What did this mean?

Create a [GitLab group](https://docs.gitlab.com/ee/user/group/) developer permissions.

@fharper
Copy link
Contributor Author

fharper commented Oct 21, 2024

I didn't write the original docs, I'm just trying to decode them.

I did but not this part 😅 I think it's a typo, or it was before we created ourselves the GitLab groups admins & developers. @jarededwards or @johndietz can highlight us if needed.

What did this mean?

The changes I made in this PR which result in Create a [GitLab group](https://docs.gitlab.com/ee/user/group/) with the name you want., which is simply to create a GitLab group where kubefirst can create the repositories and the sub-groups.

@muse-sisay confirmed there is no permissions at the group level. It's when you add users that you define the permissions, which is out of scope for kubefirst docs as it's GitLab specific and not needed for kubefirst.

@fharper fharper closed this Oct 21, 2024
@fharper
Copy link
Contributor Author

fharper commented Oct 21, 2024

😅

@fharper fharper reopened this Oct 21, 2024
@fharper
Copy link
Contributor Author

fharper commented Oct 21, 2024

push the wrong button, this PR isn't close until approved and merged, my bad 🤦‍♂️

@muse-sisay
Copy link
Contributor

Hey @bil9000,

The role option that you see when you create a group is for marketing purpose. Your user (the user who creates the group) is automatically granted an owner role.

I didn't write the original docs, I'm just trying to decode them.
What did this mean?

If you are a member of group, you need to at-least have developer role (permission) to be able to create groups and repositories( have Kubefirst create on your behalf).

@fharper fharper merged commit 57a9b11 into main Oct 21, 2024
15 checks passed
@fharper fharper deleted the fharper/gitlab branch October 21, 2024 19:44
@bil9000
Copy link

bil9000 commented Oct 21, 2024

Thank you for the clarification @muse-sisay ! You rule!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants