Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitOps Catalog] Add Cilium to gitops-catalog #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipu989
Copy link

@dipu989 dipu989 commented Sep 22, 2024

Issue link

I've put together a PR to add Cilium to the GitOps catalog.

This is my first time contributing to the konstructio repo, so I'd really appreciate it if you could take a look 👀. Open to any feedback or suggestions for improvement 🚀.

By the way, the video from @johndietz and @fharper on how to add an app to the GitOps catalog was super fun to watch and made it easy to follow along, so this PR is a result of that 🤞

@dipu989
Copy link
Author

dipu989 commented Sep 22, 2024

I just added the GPG key to my GitHub profile settings, and now commits are showing up as verified.
Can you please retrigger the checks? This should pass now.
FYI: @johndietz @fharper

@patrickdappollonio
Copy link
Member

Hey @dipu989!

Thank you for your contribution! I want to hold off this PR since enabling Cilium has a few implications in the cluster and pod lifecycle (chances are, after installing it, you might need to restart all pods so they can pick up Cilium's networking instead of the default flow or something along those lines).

Internally we're discussing about the best way to achieve this and where in the lifecycle of Kubefirst would be the time to install it.

Allow us a few days to get to a conscious answer.

@dipu989
Copy link
Author

dipu989 commented Sep 23, 2024

@patrickdappollonio Interesting problem.
No issues, Please take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants