Fix GameState.DeepClone to properly handle cloned Factions

src/game-lib/Model/MissionSite.cs

@@ -101,8 +101,15 @@ private void Expire(int turnExpired)
     private void AssertStatusInvariant()
         => Contract.Assert(IsActive ^ IsExpired ^ WasLaunched);
 
-    public MissionSite DeepClone()
+    public MissionSite DeepClone(Faction clonedFaction)
     {
-        return (MissionSite) MemberwiseClone();
+        return new MissionSite(
+            id: Id,
+            faction: clonedFaction,
+            difficulty: Difficulty,
+            turnAppeared: TurnAppeared,
+            expiresIn: ExpiresIn,
+            turnDeactivated: TurnDeactivated,
+            expired: Expired);
     }
 }

src/game-lib/Model/MissionSites.cs

@@ -18,8 +18,12 @@ public MissionSites(IEnumerable<MissionSite>? missionSites = null)
 
     public MissionSites Expired => this.Where(missionSite => missionSite.IsExpired).ToMissionSites();
 
-    public MissionSites DeepClone()
+    public MissionSites DeepClone(Factions clonedFactions)
     {
-        return new MissionSites(this.Select(missionSite => missionSite.DeepClone()));
+        return new MissionSites(this.Select(missionSite =>
+        {
+            Faction clonedFaction = clonedFactions.Single(clonedFaction => clonedFaction.Id == missionSite.Faction.Id);
+            return missionSite.DeepClone(clonedFaction);
+        }));
     }
 }

src/game-lib/State/GameState.cs

@@ -95,9 +95,8 @@ public GameState Clone(bool useJsonSerialization = false)
 
     private GameState DeepClone()
     {
-        // kja these clonedFactions will need to be passed as input to MissionSites DeepClone
         Factions clonedFactions = Factions.DeepClone();
-        MissionSites clonedMissionSites = MissionSites.DeepClone();
+        MissionSites clonedMissionSites = MissionSites.DeepClone(clonedFactions);
         Missions clonedMissions = Missions.DeepClone(clonedMissionSites);
         return new GameState(
             updateCount: UpdateCount,