dedup type and const array definitions of player actions

konrad-jamrozik · Jul 10, 2024 · 8a166c7 · 8a166c7
1 parent 2370728
commit 8a166c7
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/web/src/lib/codesync/PlayerActionEvent.ts b/web/src/lib/codesync/PlayerActionEvent.ts
@@ -6,33 +6,27 @@ export type PlayerActionEvent = GameEventBase & {
   readonly TargetId: number | undefined
 }
 
-export type PlayerActionName =
-  | 'AdvanceTimePlayerAction'
-  | 'BuyTransportCapacityPlayerAction'
-  | 'HireAgentsPlayerAction'
-  | 'LaunchMissionPlayerAction'
-  | 'InvestIntelPlayerAction'
-  | AgentPlayerActionName
+export const AgentPlayerActionNameVal = [
+  'RecallAgentsPlayerAction',
+  'SackAgentsPlayerAction',
+  'SendAgentsToGatherIntelPlayerAction',
+  'SendAgentsToGenerateIncomePlayerAction',
+  'SendAgentsToTrainingPlayerAction',
+] as const
 
-export type AgentPlayerActionName =
-  | 'SackAgentsPlayerAction'
-  | 'SendAgentsToGenerateIncomePlayerAction'
-  | 'SendAgentsToGatherIntelPlayerAction'
-  | 'SendAgentsToTrainingPlayerAction'
-  | 'RecallAgentsPlayerAction'
+export type AgentPlayerActionName = (typeof AgentPlayerActionNameVal)[number]
 
-export const PlayerActionNameVal: PlayerActionName[] = [
+export const PlayerActionNameVal = [
   'AdvanceTimePlayerAction',
   'BuyTransportCapacityPlayerAction',
   'HireAgentsPlayerAction',
   'InvestIntelPlayerAction',
   'LaunchMissionPlayerAction',
   'SackAgentsPlayerAction',
-  'SendAgentsToGenerateIncomePlayerAction',
-  'SendAgentsToGatherIntelPlayerAction',
-  'SendAgentsToTrainingPlayerAction',
-  'RecallAgentsPlayerAction',
-]
+  ...AgentPlayerActionNameVal,
+] as const
+
+export type PlayerActionName = (typeof PlayerActionNameVal)[number]
 
 export type PlayerActionNameInTurn = Exclude<
   PlayerActionName,