Skip to content

Commit

Permalink
update todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Konrad Jamrozik committed Jun 26, 2024
1 parent b439060 commit 574d390
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions src/game-lib/Lib/IdGen.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ public class IdGen

public int Value => NextId;

// kja need to assert AssertConsecutiveIds across entire game session
public static void AssertConsecutiveIds<T>(List<T> instances, int? expectedFirstId = null) where T: IIdentifiable
public static void AssertConsecutiveIds<T>(List<T> instances, int? expectedFirstId = null) where T : IIdentifiable
{
if (instances.Any())
{
Expand All @@ -28,4 +27,4 @@ public static void AssertConsecutiveIds<T>(List<T> instances, int? expectedFirst
}
}
}
}
}
3 changes: 2 additions & 1 deletion src/game-lib/Model/Ruleset.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static class Ruleset
// kja-refact: Power should be "actual" value, not with the precision. So 40 instead of 400. Then powerIncrease (to be renamed to powerClimb)
// would be 0.4 and powerAcceleration would be 0.008. This would make it easier to reason about the values.
// Just bite the bullet and use doubles.
// kja also, frontend diagram chart shows the increased precision (e.g. 100) while datagrid shows normalzied (e.g. 10).
Faction.Init(randomGen, id: 0, "Black Lotus cult", power: 200, powerIncrease: 4, powerAcceleration: 8),
Faction.Init(randomGen, id: 1, "Red Dawn remnants", power: 300, powerIncrease: 5, powerAcceleration: 5),
Faction.Init(randomGen, id: 2, "EXALT", power: 400, powerIncrease: 6, powerAcceleration: 4),
Expand Down Expand Up @@ -140,4 +141,4 @@ public static int ComputeIntelChange(Assets assets, List<Mission> successfulMiss

public static int TransportCapacityBuyingCost(int capacity)
=> capacity * 200;
}
}

0 comments on commit 574d390

Please sign in to comment.