fix(RELEASE-1441): remove rsc from being managed #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
scoheb
commented
Feb 11, 2025
scoheb
commented
- the rsc needs to managed outside of the release service so that clusters can have a specific version for testing.
- A version can be deployed and managed by ArgoCD via infra-deployments for a specific cluster
|
/retest |
scoheb
force-pushed
the
release-service-config-by-env
branch
from
22cd46b to
b87804a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 79.23% 78.69% -0.55%
==========================================
Files 28 28
Lines 2283 2807 +524
==========================================
+ Hits 1809 2209 +400
- Misses 389 495 +106
- Partials 85 103 +18 ☔ View full report in Codecov by Sentry. |
|
/retest |
johnbieren
reviewed
Feb 11, 2025
scoheb
force-pushed
the
release-service-config-by-env
branch
from
b87804a to
e2953e3
Compare
johnbieren
approved these changes
Feb 12, 2025
- the rsc needs to managed outside of the release service so that clusters can have a specific version for testing. - A version can be deployed and managed by ArgoCD via infra-deployments for a specific cluster Signed-off-by: Scott Hebert <[email protected]>
scoheb
force-pushed
the
release-service-config-by-env
branch
from
e2953e3 to
7ef3cb0
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.