Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1372): migrate off of gcr.io #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

davidmogar
Copy link
Collaborator

@davidmogar davidmogar commented Feb 11, 2025

This change modifies the manager to migrate off of gcr.io for kube-rbac-proxy. This requires a controller-runtime update, so several unrelated changes needed to be added.

NOTE: Ideally I would have upgraded go to 1.23 but there's no ubi image supplying this. For the tests to past I had to limit the upgrade so we don't jump into 1.23 nor forces the go.mod to include a toolchain. I also had to bum tools versions for everything to work properly with the new deps.

@davidmogar davidmogar requested a review from a team as a code owner February 11, 2025 14:28
@davidmogar davidmogar force-pushed the release1372 branch 19 times, most recently from c094f18 to 9fd6cc9 Compare February 13, 2025 09:23
@davidmogar davidmogar force-pushed the release1372 branch 7 times, most recently from 65d5314 to fdc9ab2 Compare February 13, 2025 14:59
@davidmogar
Copy link
Collaborator Author

/retest

@davidmogar
Copy link
Collaborator Author

/retest

johnbieren
johnbieren previously approved these changes Feb 14, 2025
@openshift-ci openshift-ci bot added the lgtm label Feb 18, 2025
This change modifies the manager to migrate off of gcr.io
for kube-rbac-proxy. This requires a controller-runtime
update, so several unrelated changes needed to be added.

Signed-off-by: David Moreno García <[email protected]>
Copy link

openshift-ci bot commented Feb 20, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2025
@konflux-ci-qe-bot
Copy link

@davidmogar: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-r65ww Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service:konflux-e2e-tests-r65ww

Test results analysis

🚨 Failed to provision a cluster, see the log for more details:

Click to view logs
INFO: Log in to your Red Hat account...
INFO: Configure AWS Credentials...
WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.50).
WARN: It is recommended that you update to the latest version.
INFO: Logged in as 'konflux-ci-418295695583' on 'https://api.openshift.com'
INFO: Create ROSA with HCP cluster...
WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.50).
WARN: It is recommended that you update to the latest version.
INFO: Creating cluster 'kx-306e888058'
INFO: To view a list of clusters and their status, run 'rosa list clusters'
INFO: Cluster 'kx-306e888058' has been created.
INFO: Once the cluster is installed you will need to add an Identity Provider before you can login into the cluster. See 'rosa create idp --help' for more information.

Name: kx-306e888058
Domain Prefix: kx-306e888058
Display Name: kx-306e888058
ID: 2h2bikuo6rg2t35t7jrks9fc5jg4fh63
External ID: f03f2ba9-39fa-4016-9b16-e90ba32ba73c
Control Plane: ROSA Service Hosted
OpenShift Version: 4.15.45
Channel Group: stable
DNS: Not ready
AWS Account: 418295695583
AWS Billing Account: 418295695583
API URL:
Console URL:
Region: us-east-1
Availability:

  • Control Plane: MultiAZ
  • Data Plane: SingleAZ

Nodes:

  • Compute (desired): 3
  • Compute (current): 0
    Network:
  • Type: OVNKubernetes
  • Service CIDR: 172.30.0.0/16
  • Machine CIDR: 10.0.0.0/16
  • Pod CIDR: 10.128.0.0/14
  • Host Prefix: /23
  • Subnets: subnet-05b9daa0609597f68, subnet-04cf6376374bf9e09
    EC2 Metadata Http Tokens: optional
    Role (STS) ARN: arn:aws:iam::418295695583:role/ManagedOpenShift-HCP-ROSA-Installer-Role
    Support Role ARN: arn:aws:iam::418295695583:role/ManagedOpenShift-HCP-ROSA-Support-Role
    Instance IAM Roles:
  • Worker: arn:aws:iam::418295695583:role/ManagedOpenShift-HCP-ROSA-Worker-Role
    Operator IAM Roles:
  • arn:aws:iam::418295695583:role/rosa-hcp-openshift-ingress-operator-cloud-credentials
  • arn:aws:iam::418295695583:role/rosa-hcp-openshift-cluster-csi-drivers-ebs-cloud-credentials
  • arn:aws:iam::418295695583:role/rosa-hcp-openshift-cloud-network-config-controller-cloud-credent
  • arn:aws:iam::418295695583:role/rosa-hcp-openshift-image-registry-installer-cloud-credentials
  • arn:aws:iam::418295695583:role/rosa-hcp-kube-system-kms-provider
  • arn:aws:iam::418295695583:role/rosa-hcp-kube-system-kube-controller-manager
  • arn:aws:iam::418295695583:role/rosa-hcp-kube-system-capa-controller-manager
  • arn:aws:iam::418295695583:role/rosa-hcp-kube-system-control-plane-operator
    Managed Policies: Yes
    State: waiting (Waiting for user action)
    Private: No
    Delete Protection: Disabled
    Created: Feb 20 2025 10:43:36 UTC
    User Workload Monitoring: Enabled
    Details Page: https://console.redhat.com/openshift/details/s/2tImyKfcjlG8K6ZbqGH6dW5x5jR
    OIDC Endpoint URL: https://oidc.op1.openshiftapps.com/2du11g36ejmoo4624pofphlrgf4r9tf3 (Managed)
    Etcd Encryption: Disabled
    Audit Log Forwarding: Disabled
    External Authentication: Disabled
    Zero Egress: Disabled

INFO: Preparing to create operator roles.
INFO: Operator Roles already exists
INFO: Preparing to create OIDC Provider.
INFO: OIDC provider already exists
INFO: To determine when your cluster is Ready, run 'rosa describe cluster -c kx-306e888058'.
INFO: To watch your cluster installation logs, run 'rosa logs install -c kx-306e888058 --watch'.
INFO: Track the progress of the cluster creation...
WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.50).
WARN: It is recommended that you update to the latest version.
�[0;33mW:�[m Region flag will be removed from this command in future versions
INFO: Cluster 'kx-306e888058' is in waiting state waiting for installation to begin. Logs will show up within 5 minutes
0001-01-01 00:00:00 +0000 UTC hostedclusters kx-306e888058 Version
2025-02-20 10:48:29 +0000 UTC hostedclusters kx-306e888058 ValidAWSIdentityProvider StatusUnknown
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Waiting for hosted control plane to be healthy
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Ignition server deployment not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 HostedCluster is supported by operator configuration
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Release image is valid
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Reconciliation active on resource
2025-02-20 10:48:34 +0000 UTC hostedclusters kx-306e888058 HostedCluster is at expected version
2025-02-20 10:48:41 +0000 UTC hostedclusters kx-306e888058 Required platform credentials are found
2025-02-20 10:48:41 +0000 UTC hostedclusters kx-306e888058 failed to get referenced secret ocm-production-2h2bikuo6rg2t35t7jrks9fc5jg4fh63/cluster-api-cert: Secret "cluster-api-cert" not found
0001-01-01 00:00:00 +0000 UTC hostedclusters kx-306e888058 Version
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Release image is valid
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Ignition server deployment not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 router load balancer is not provisioned; 5s since creation.; private-router load balancer is not provisioned; 5s since creation.; router load balancer is not provisioned; 5s since creation.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 HostedCluster is supported by operator configuration
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Reconciliation active on resource
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:48:34 +0000 UTC hostedclusters kx-306e888058 HostedCluster is at expected version
2025-02-20 10:48:41 +0000 UTC hostedclusters kx-306e888058 Required platform credentials are found
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 OIDC configuration is valid
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 Reconciliation completed successfully
2025-02-20 10:50:15 +0000 UTC hostedclusters kx-306e888058 WebIdentityErr
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 lookup api.kx-306e888058.39ei.p3.openshiftapps.com on 172.30.0.10:53: no such host
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 capi-provider deployment has 1 unavailable replicas
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 AWS KMS is not configured
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 EtcdAvailable StatefulSetNotFound
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Kube APIServer deployment not found
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 router load balancer is not provisioned; 5s since creation.; private-router load balancer is not provisioned; 5s since creation.; router load balancer is not provisioned; 5s since creation.
0001-01-01 00:00:00 +0000 UTC hostedclusters kx-306e888058 Version
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Release image is valid
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Ignition server deployment not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 router load balancer is not provisioned; 34s since creation.; private-router load balancer is not provisioned; 34s since creation.; router load balancer is not provisioned; 34s since creation.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 HostedCluster is supported by operator configuration
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Reconciliation active on resource
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:48:34 +0000 UTC hostedclusters kx-306e888058 HostedCluster is at expected version
2025-02-20 10:48:41 +0000 UTC hostedclusters kx-306e888058 Required platform credentials are found
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 OIDC configuration is valid
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 Reconciliation completed successfully
2025-02-20 10:50:15 +0000 UTC hostedclusters kx-306e888058 WebIdentityErr
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 lookup api.kx-306e888058.39ei.p3.openshiftapps.com on 172.30.0.10:53: no such host
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 capi-provider deployment has 1 unavailable replicas
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 AWS KMS is not configured
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 EtcdAvailable StatefulSetNotFound
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Kube APIServer deployment not found
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 router load balancer is not provisioned; 34s since creation.; private-router load balancer is not provisioned; 34s since creation.; router load balancer is not provisioned; 34s since creation.
0001-01-01 00:00:00 +0000 UTC hostedclusters kx-306e888058 Version
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Release image is valid
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Ignition server deployment not found
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Waiting for hosted control plane kubeconfig to be created
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 HostedCluster is supported by operator configuration
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Condition not found in the CVO.
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Reconciliation active on resource
2025-02-20 10:48:31 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:48:34 +0000 UTC hostedclusters kx-306e888058 HostedCluster is at expected version
2025-02-20 10:48:41 +0000 UTC hostedclusters kx-306e888058 Required platform credentials are found
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 OIDC configuration is valid
2025-02-20 10:50:14 +0000 UTC hostedclusters kx-306e888058 Reconciliation completed successfully
2025-02-20 10:50:15 +0000 UTC hostedclusters kx-306e888058 WebIdentityErr
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 lookup api.kx-306e888058.39ei.p3.openshiftapps.com on 172.30.0.10:53: no such host
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 capi-provider deployment has 1 unavailable replicas
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Configuration passes validation
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 AWS KMS is not configured
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Waiting for etcd to reach quorum
2025-02-20 10:50:17 +0000 UTC hostedclusters kx-306e888058 Kube APIServer deployment not found
2025-02-20 10:51:22 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:52:16 +0000 UTC hostedclusters kx-306e888058 EtcdAvailable QuorumAvailable
2025-02-20 10:53:18 +0000 UTC hostedclusters kx-306e888058 Kube APIServer deployment is available
2025-02-20 10:53:27 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:53:43 +0000 UTC hostedclusters kx-306e888058 [catalog-operator deployment has 1 unavailable replicas, certified-operators-catalog deployment has 2 unavailable replicas, cloud-credential-operator deployment has 1 unavailable replicas, cluster-network-operator deployment has 1 unavailable replicas, cluster-storage-operator deployment has 1 unavailable replicas, community-operators-catalog deployment has 2 unavailable replicas, csi-snapshot-controller-operator deployment has 1 unavailable replicas, dns-operator deployment has 1 unavailable replicas, hosted-cluster-config-operator deployment has 1 unavailable replicas, ignition-server deployment has 3 unavailable replicas, ingress-operator deployment has 1 unavailable replicas, olm-operator deployment has 1 unavailable replicas, packageserver deployment has 3 unavailable replicas, redhat-marketplace-catalog deployment has 2 unavailable replicas, redhat-operators-catalog deployment has 2 unavailable replicas, router deployment has 1 unavailable replicas]
2025-02-20 10:53:59 +0000 UTC hostedclusters kx-306e888058 All is well
2025-02-20 10:54:08 +0000 UTC hostedclusters kx-306e888058 The hosted control plane is available
INFO: Cluster 'kx-306e888058' is now ready
INFO: ROSA with HCP cluster is ready, create a cluster admin account for accessing the cluster
WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.50).
WARN: It is recommended that you update to the latest version.
INFO: Storing login command...
INFO: Check if it's able to login to OCP cluster...
Retried 1 times...
INFO: Check if apiserver is ready...
[INFO] Checking cluster operators' status...
[INFO] Attempt 1/10
NAME VERSION AVAILABLE PROGRESSING DEGRADED SINCE MESSAGE
console
csi-snapshot-controller 4.15.45 True False False 3m17s
dns 4.15.45 False False True 3m32s DNS "default" is unavailable.
image-registry False True True 2m56s Available: The deployment does not have available replicas...
ingress False True True 2m55s The "default" ingress controller reports Available=False: IngressControllerUnavailable: One or more status conditions indicate unavailable: DeploymentAvailable=False (DeploymentUnavailable: The deployment has Available status condition set to False (reason: MinimumReplicasUnavailable) with message: Deployment does not have minimum availability.)
insights
kube-apiserver 4.15.45 True False False 3m35s
kube-controller-manager 4.15.45 True False False 3m34s
kube-scheduler 4.15.45 True False False 3m34s
kube-storage-version-migrator
monitoring
network 4.15.45 True True False 3m9s DaemonSet "/openshift-multus/network-metrics-daemon" is waiting for other operators to become ready...
node-tuning False True False 3m28s DaemonSet "tuned" has no available Pod(s)
openshift-apiserver 4.15.45 True False False 3m35s
openshift-controller-manager 4.15.45 True False False 3m35s
openshift-samples
operator-lifecycle-manager 4.15.45 True False False 3m33s
operator-lifecycle-manager-catalog 4.15.45 True False False 3m36s
operator-lifecycle-manager-packageserver 4.15.45 True False False 3m34s
service-ca
storage 4.15.45 False False False 3m30s AWSEBSCSIDriverOperatorCRAvailable: AWSEBSDriverNodeServiceControllerAvailable: Waiting for the DaemonSet to deploy the CSI Node Service
[INFO] Cluster operators are accessible.
[INFO] Waiting for cluster operators to be in 'Progressing=false' state...
clusteroperator.config.openshift.io/console condition met
clusteroperator.config.openshift.io/csi-snapshot-controller condition met
clusteroperator.config.openshift.io/dns condition met
clusteroperator.config.openshift.io/image-registry condition met
clusteroperator.config.openshift.io/ingress condition met
clusteroperator.config.openshift.io/insights condition met
clusteroperator.config.openshift.io/kube-apiserver condition met
clusteroperator.config.openshift.io/kube-controller-manager condition met
clusteroperator.config.openshift.io/kube-scheduler condition met
clusteroperator.config.openshift.io/kube-storage-version-migrator condition met
clusteroperator.config.openshift.io/monitoring condition met
clusteroperator.config.openshift.io/network condition met
clusteroperator.config.openshift.io/node-tuning condition met
clusteroperator.config.openshift.io/openshift-apiserver condition met
clusteroperator.config.openshift.io/openshift-controller-manager condition met
clusteroperator.config.openshift.io/openshift-samples condition met
clusteroperator.config.openshift.io/operator-lifecycle-manager condition met
clusteroperator.config.openshift.io/operator-lifecycle-manager-catalog condition met
clusteroperator.config.openshift.io/operator-lifecycle-manager-packageserver condition met
clusteroperator.config.openshift.io/service-ca condition met
clusteroperator.config.openshift.io/storage condition met


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants