feat(RELEASE-1400): add references in populate-release-notes task #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
johnbieren
force-pushed
the
release1400
branch
4 times, most recently
from
0f8fdf9 to
3b4aa8b
Compare
mmalina
reviewed
Feb 4, 2025
tasks/managed/populate-release-notes/populate-release-notes.yaml
Outdated
Show resolved
Hide resolved
mmalina
reviewed
Feb 4, 2025
johnbieren
force-pushed
the
release1400
branch
3 times, most recently
from
6a460e1 to
0dc48cb
Compare
mmalina
reviewed
Feb 5, 2025
tasks/managed/populate-release-notes/tests/test-populate-release-notes-non-rhsa-references.yaml
Outdated
Show resolved
Hide resolved
johnbieren
force-pushed
the
release1400
branch
from
0dc48cb to
886b99e
Compare
This commit renames the populate-release-notes-images task to populate-release-notes. The new version of the task adds references if the type is RHSA. One is a static reference and there is also a reference added per CVE listed in releaseNotes. Because references will no longer need to be passed for RHBA or RHEA as part of this work, this commit also updates the schema to not require references when using releaseNotes. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
release1400
branch
from
886b99e to
6fd3e10
Compare
|
/retest |
1 similar comment
|
/retest |
mmalina
approved these changes
Feb 6, 2025
|
e2e passed and the PR is approved. Auto-merge is not enabled, so I'm a bit hesitant if you'd want me to merge it, but hopefully it's ok. |
|
Yep, I wanted it merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the populate-release-notes-images task to populate-release-notes. The new version of the task adds references if the type is RHSA. One is a static reference and there is also a reference added per CVE listed in releaseNotes.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>