Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RELEASE-1361): accept arrays for cpe and product_id #801

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

johnbieren
Copy link
Collaborator

This commit modifies the schemafile to allow arrays for releaseNotes.product_id and releaseNotes.cpe. This is a temporary measure to ensure backwards compatibility; a future commit will remove the singleton types so that only an array is allowed for each.

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

@johnbieren johnbieren requested a review from a team as a code owner February 3, 2025 18:31
happybhati
happybhati previously approved these changes Feb 3, 2025
schema/dataKeys.json Outdated Show resolved Hide resolved
@johnbieren
Copy link
Collaborator Author

/retest

This commit modifies the schemafile to allow arrays for
releaseNotes.product_id and releaseNotes.cpe. This is a temporary
measure to ensure backwards compatibility; a future commit will remove
the singleton types so that only an array is allowed for each.

Signed-off-by: Johnny Bieren <[email protected]>
Copy link

openshift-ci bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@johnbieren johnbieren enabled auto-merge (squash) February 5, 2025 14:33
@johnbieren johnbieren merged commit 0599955 into konflux-ci:development Feb 5, 2025
8 checks passed
@johnbieren johnbieren deleted the release1361 branch February 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants