-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1291): use trusted artifacts #784
Open
scoheb
wants to merge
20
commits into
konflux-ci:development
Choose a base branch
from
scoheb:use-trusted-artifacts
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,589
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping CI for Draft Pull Request. |
scoheb
force-pushed
the
use-trusted-artifacts
branch
28 times, most recently
from
January 28, 2025 18:28
c5831b5
to
92310a3
Compare
scoheb
force-pushed
the
use-trusted-artifacts
branch
4 times, most recently
from
February 3, 2025 18:23
99ee85f
to
7764841
Compare
- in an effort to move away from PVCs, we are trying trusted artifacts. - this PR makes the following changes: - PipelineRun uses an EmptyDir now for the workspace - the subDirectory parameter is removed - the data path is now saved as an artifact in quay - the check-result task then uses it for testing - a local registry is installed on the cluster under test in order to create and use trusted artifacts during testing - If we go ahead with this, then we would create a new task called `collect-data-oci-ta` alongside `collect-data` and gradually build up new `-oci-ta` pipelines. Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
- 1 run as PVC based - 1 run as Trusted Artifacts based if found Signed-off-by: Scott Hebert <[email protected]>
- remove DEBUG env vars Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
Signed-off-by: Scott Hebert <[email protected]>
scoheb
force-pushed
the
use-trusted-artifacts
branch
from
February 3, 2025 18:40
7764841
to
b8b89bc
Compare
scoheb
changed the title
feat: use trusted artifacts
feat(RELEASE-1291): use trusted artifacts
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
trusted artifacts based on https://github.com/konflux-ci/build-trusted-artifacts/tree/main
requires konflux-ci/release-service@c92d422 for use on real clusters
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>