feat(KFLUXUI-175): give up SpaceBindingRequest and enjoy RoleBinding #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testcara
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 80.09% 80.19% +0.09%
==========================================
Files 570 575 +5
Lines 21476 21618 +142
Branches 5326 5334 +8
==========================================
+ Hits 17202 17337 +135
- Misses 4249 4256 +7
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
testcara
force-pushed
the
KFLUXUI-251
branch
2 times, most recently
from
a75a873 to
3371d76
Compare
testcara
changed the title
testcara
requested review from
sahil143,
CryptoRodeo,
caugello,
JoaoPedroPP,
StanislavJochman and
marcin-michal
|
looks good first pass, I'll run this locally and label |
sahil143
requested changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
KFLUXUI-175
Description
Konflux is migrating off workspace api and also the related SpaceBindingRequest.
For Konflux UI, we need to enjoy the shared Konflux cluster role and rolebinding for the namespace access and permission checks.
For the details:
We use k8swatch the rolebinding of the namespace for the list page.
And for the form actions, we use the create rolebinding, delete rolebinding, get rolebindings.
More, the status of the user access list are removed.
Type of change
Screen shots / Gifs for design review
Screen.Recording.2025-01-22.at.15.30.33.mov
How to test or reproduce?
Just enjoy the use access page as previous.
You can visit access list, grant access, edit access, revoke access like before.
Browser conformance: