fix(KONFLUX-6398): fixes swapped pid and taskRunID #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
========================================
Coverage 80.15% 80.15%
========================================
Files 569 569
Lines 21391 21391
Branches 5291 5041 -250
========================================
Hits 17146 17146
- Misses 4220 4221 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gbenhaim
reviewed
Jan 14, 2025
| taskRun?.metadata?.uid, | ||
| pipelineRunUID, |
There was a problem hiding this comment.
since you've changed the order of parameters and arguments as well, doe this PR changes something?
There was a problem hiding this comment.
Still needs testing because not on all places it is changed. But I do not have access to test it so trying to get that.
sahil143
approved these changes
Jan 15, 2025
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.