fix(KFLUXBUGS-1342): add existing secret in the components secret form #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: list existing secret in build time secret modal
JoaoPedroPP
force-pushed
the
KONFLUX-5921
branch
from
9d4dfa4 to
d8051ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 80.01% 79.99% -0.03%
==========================================
Files 569 569
Lines 21380 21405 +25
Branches 5036 5048 +12
==========================================
+ Hits 17108 17123 +15
- Misses 4248 4258 +10
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Let me know when you will have it ready. Will pull it and try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
KFLUXBUGS-1342
Description
When onboarding a new component and adding a build time secret, the dialog cannot find an existing secret in the workspace.