-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unblock component list loading from pipeline runs #60
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
========================================
Coverage 80.01% 80.02%
========================================
Files 569 569
Lines 21380 21383 +3
Branches 5036 5288 +252
========================================
+ Hits 17108 17111 +3
+ Misses 4248 4247 -1
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I approve the solution
package.json
Outdated
@@ -98,7 +99,8 @@ | |||
"webpack-cli": "^5.1.4", | |||
"webpack-dev-server": "^5.0.4", | |||
"webpack-merge": "^6.0.1", | |||
"whatwg-fetch": "^3.6.20" | |||
"whatwg-fetch": "^3.6.20", | |||
"zx": "^8.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, the zx package looks very useful
do we show all pipeline runs of the component to users? with times change, pipeline runs would be more and more but most of historical data are useless to users. How about we just show latest 1 month or 2 months? for others, show link to users directing users to get the raw data the linked api directly? |
The background fetching is helpful to improve current problem. Good improvement. LGTM. |
e9dd53c
to
316bec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I approve it.
https://issues.redhat.com/browse/KONFLUX-5766
The components list page takes too long to load because it waits for all pipeline runs to be fetched. Since an application can have a large number of associated pipeline runs, the UI currently fetches only 30 pipeline runs per request, causing the page to wait until all requests are completed.
Proposed Solution:
The UI should load the page as soon as the components are available and fetch the pipeline runs in the background. Each row should display a loading indicator for the pipeline runs. As soon as the pipeline run for a specific component is fetched, it should be displayed on the UI while the remaining pipeline runs continue to load in the background.
NOTE:
Added a script to create large number of components for testing purposes. I will remove the script once the PR is tested and approved.