Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline-run): open websocket in case of abnormally closed, implement polling, releases watch #43

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

sahil143
Copy link
Collaborator

@sahil143 sahil143 commented Nov 28, 2024

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 88.60759% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (ed4ee3e) to head (16b17e7).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/k8s/hooks/useK8sQueryWatch.ts 91.11% 4 Missing ⚠️
...elineRunDetailsView/tabs/PipelineRunDetailsTab.tsx 0.00% 2 Missing ⚠️
...omponents/ComponentsListView/ComponentListView.tsx 0.00% 1 Missing ⚠️
src/hooks/useReleases.ts 0.00% 1 Missing ⚠️
src/k8s/k8s-utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   79.60%   79.67%   +0.07%     
==========================================
  Files         564      565       +1     
  Lines       20977    21052      +75     
  Branches     4951     4965      +14     
==========================================
+ Hits        16698    16773      +75     
  Misses       4255     4255              
  Partials       24       24              
Flag Coverage Δ
unittests 79.67% <88.60%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this branch to run E2E tests locally and it worked well. Approving.

@sahil143 sahil143 merged commit 8297d54 into konflux-ci:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants