fix(KFLUXUI-194): update usage of build trigger #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptoRodeo
force-pushed
the
kfluxui-194
branch
from
c275907 to
9fa45d5
Compare
CryptoRodeo
changed the title
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 79.78% 79.76% -0.03%
==========================================
Files 568 567 -1
Lines 21261 21228 -33
Branches 5017 5264 +247
==========================================
- Hits 16963 16932 -31
+ Misses 4274 4271 -3
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/ok-to-test |
|
After taking a look at the lines from Codecov, I believe that code coverage can be ignored here. |
CryptoRodeo
force-pushed
the
kfluxui-194
branch
from
cac94b9 to
e328a06
Compare
sahil143
requested changes
Dec 3, 2024
| @@ -30,14 +27,12 @@ export const getContainerImageLink = (url: string) => { | |||
|
|
|||
| const ComponentsListRow: React.FC< | |||
| RowFunctionArgs<ComponentWithLatestBuildPipeline, PacStatesForComponents> | |||
| > = ({ obj: component, customData }) => { | |||
| > = ({ obj: component }) => { | |||
There was a problem hiding this comment.
If we do not need that customData, Please remove the data passed to customData in the ComponentListView Table component.
There was a problem hiding this comment.
Add a tooltip for build trigger details page. Remove two columns from the component activity page.
CryptoRodeo
force-pushed
the
kfluxui-194
branch
from
e328a06 to
dc8329e
Compare
sahil143
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tooltip for build trigger details page.
Remove two columns from the component activity page.
Backport of openshift/hac-dev#993