Skip to content

Commit

Permalink
fix: add konflux favicon (#69)
Browse files Browse the repository at this point in the history
* fix: add konflux favicon

* chore: update readme to include node and yarn version

* chore: add pull request template
  • Loading branch information
sahil143 authored Jan 16, 2025
1 parent e47e5f9 commit f381e70
Show file tree
Hide file tree
Showing 4 changed files with 60 additions and 1 deletion.
53 changes: 53 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@

## Fixes
<!-- For e.g Fixes: https://issues.redhat.com/browse/HAC-XXX -->


## Description
<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->


## Type of change
<!-- Please delete options that are not relevant. -->

- [ ] Feature
- [ ] Bugfix
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## Screen shots / Gifs for design review
<!-- If change affects UI in any way, tag relevant UX people and add screenshots/gifs -->


## How to test or reproduce?
<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration -->

<!-- - [ ] Test A -->
<!-- - [ ] Test B -->

<!-- **Test Configuration(s)**: -->


## Browser conformance:
<!-- To mark tested browsers, use [x] -->
- [ ] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge


<!-- ## Checklist: -->

<!--
- [ ] Code follows the style guidelines
- [ ] Self-reviewed the code
- [ ] Added comments in hard-to-understand areas
- [ ] Made corresponding changes to the documentation
- [ ] Changes generate no new warnings
- [ ] Added tests that prove this fix is effective or that the feature works
- [ ] New and existing unit tests pass locally with new changes
- [ ] Any dependent changes have been merged and published in downstream modules
-->
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ UI for [Konflux](https://github.com/konflux-ci/konflux-ci)

### Installing

**Prerequisites:**
- Node.js version >= 20
- Yarn version 1.22

A step by step series of examples that tell you how to get a development environment running:

1. Clone the repository
Expand Down
Binary file added public/favicon.ico
Binary file not shown.
4 changes: 3 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export default {
},
],
},
plugins: [new HtmlWebpackPlugin({ template: './public/index.html' })],
plugins: [
new HtmlWebpackPlugin({ template: './public/index.html', favicon: './public/favicon.ico' }),
],
optimization: {
moduleIds: 'deterministic',
runtimeChunk: 'single',
Expand Down

0 comments on commit f381e70

Please sign in to comment.