fix(Release): add unit tests for overview tab and snapshot details view

konflux-ci · Nov 27, 2024 · a5429d6 · a5429d6
1 parent c91faa2
commit a5429d6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/components/Releases/__tests__/ReleaseOverviewTab.spec.tsx b/src/components/Releases/__tests__/ReleaseOverviewTab.spec.tsx
@@ -19,13 +19,18 @@ jest.mock('../../../hooks/useReleases', () => ({
 const watchResourceMock = createK8sWatchResourceMock();
 
 describe('ReleaseOverviewTab', () => {
-  beforeEach(() => {
-    watchResourceMock.mockReturnValue([{ spec: { application: 'test-app' } }, true]);
-  });
+  beforeEach(() => {});
 
   createUseWorkspaceInfoMock({ namespace: 'test-ns', workspace: 'test-ws' });
 
+  it('should render loading indicator', () => {
+    watchResourceMock.mockReturnValue([{ spec: { application: 'test-app' } }, false]);
+    render(<ReleaseOverviewTab />);
+    expect(screen.getByRole('progressbar')).toBeVisible();
+  });
+
   it('should render correct details', () => {
+    watchResourceMock.mockReturnValue([{ spec: { application: 'test-app' } }, true]);
     render(<ReleaseOverviewTab />);
     expect(screen.getByText('Duration')).toBeVisible();
     expect(screen.getByText('10 seconds')).toBeVisible();

diff --git a/src/components/SnapshotDetails/__tests__/SnapshotDetailsView.spec.tsx b/src/components/SnapshotDetails/__tests__/SnapshotDetailsView.spec.tsx
@@ -67,6 +67,12 @@ describe('SnapshotDetailsView', () => {
     (useCommitStatus as jest.Mock).mockReturnValueOnce(['-', true]);
   });
 
+  it('should render loading indicator', () => {
+    watchResourceMock.mockReturnValue([[], false]);
+    renderWithQueryClientAndRouter(<SnapshotDetails />);
+    screen.getByRole('progressbar');
+  });
+
   it('should show error state if test cannot be loaded', () => {
     watchResourceMock.mockReturnValue([
       [],