Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a warning message in the kustomize generated files #1927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tisutisu
Copy link
Contributor

This PR add a warning message in the kustomize generated files, to notify the users to avoid accidentally editing them

@tisutisu tisutisu requested review from kdudka and a team as code owners February 10, 2025 12:48
arewm
arewm previously approved these changes Feb 10, 2025
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

chmeliik
chmeliik previously approved these changes Feb 10, 2025
kasemAlem
kasemAlem previously approved these changes Feb 10, 2025
@tisutisu tisutisu dismissed stale reviews from kasemAlem, chmeliik, and arewm via 32b0b0b February 11, 2025 07:28
@tisutisu tisutisu force-pushed the add-warning-in-kustomize branch 3 times, most recently from d88f514 to 38d9864 Compare February 11, 2025 09:47
kasemAlem
kasemAlem previously approved these changes Feb 11, 2025
chmeliik
chmeliik previously approved these changes Feb 11, 2025
hack/build-manifests.sh Outdated Show resolved Hide resolved
@tisutisu tisutisu dismissed stale reviews from chmeliik and kasemAlem via 0cb331e February 11, 2025 12:30
@tisutisu tisutisu force-pushed the add-warning-in-kustomize branch 2 times, most recently from 0cb331e to 0277ffb Compare February 11, 2025 12:31
hack/build-manifests.sh Outdated Show resolved Hide resolved
@tisutisu tisutisu force-pushed the add-warning-in-kustomize branch from 0277ffb to 37804f5 Compare February 12, 2025 07:44
@tisutisu tisutisu force-pushed the add-warning-in-kustomize branch from 37804f5 to b691a2c Compare February 12, 2025 07:49
@tisutisu tisutisu requested a review from rnc as a code owner February 12, 2025 07:49
@tisutisu
Copy link
Contributor Author

@konflux-ci/operator-foundry @kdudka @rnc could you please review this small change?

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants