extend the sast-coverity-check CI task to support buildful scanning #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
force-pushed
the
cov-bf
branch
10 times, most recently
from
d9f50ab to
d105ef6
Compare
5 tasks
kdudka
force-pushed
the
cov-bf
branch
4 times, most recently
from
01c1285 to
31c6f24
Compare
|
/ok-to-test |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... which is not used for anything Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... which is not used for anything Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Jan 24, 2025
... which is not used for anything Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Jan 24, 2025
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Jan 24, 2025
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Jan 24, 2025
|
@jsztuka Are you reviewing this pull request on behalf of the integration team? If yes, please let me know if anything else is needed from me for this pull request to be approved. |
|
@kdudka yep, thats correct, changes seems fine. I think once updated, you are good to go. |
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
... which is not used for anything Related: konflux-ci#1653
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
... which have to be indexed by numbers due to limitations of kustomize Related: https://issues.redhat.com/browse/KONFLUX-6272
|
@jsztuka Thanks for review! I have queued this pull request for merge. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
They cause the CI to be red on tasks derived from the buildah task. Related: #1653
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: #1653
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
... which is not used for anything Related: #1653
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
... to make the interface compatible with the `build-container` task Related: #1653
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: #1653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/OSH-750