Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soroban.RPC.Server and network_passphrase configuration #150

Merged

Conversation

miguelnietoa
Copy link
Member

@miguelnietoa miguelnietoa commented Mar 6, 2024

Description

Fixes #149

This PR:

  1. Add Soroban.RPC.Server struct and receive network_passphrase in Contract functions
  2. Deprecate extra_fee_rate parameter which is not necessary due to the addl_resources parameter which will increase Soroban resource fee.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@miguelnietoa miguelnietoa requested a review from L-Zuluaga March 6, 2024 19:25
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found some small details, apart from that Looks great! 🚀

@miguelnietoa miguelnietoa requested a review from L-Zuluaga March 7, 2024 01:11
@miguelnietoa miguelnietoa merged commit 1042062 into kommitters:v0.20 Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants