Madara: Improve thumbnail (#5762)

* Improve thumbnail * Bump version
komikku-app · Oct 30, 2024 · aebd1b6 · aebd1b6
1 parent a8a11ad
commit aebd1b6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib-multisrc/madara/build.gradle.kts b/lib-multisrc/madara/build.gradle.kts
@@ -2,7 +2,7 @@ plugins {
     id("lib-multisrc")
 }
 
-baseVersionCode = 36
+baseVersionCode = 37
 
 dependencies {
     api(project(":lib:cryptoaes"))

diff --git a/lib-multisrc/madara/src/eu/kanade/tachiyomi/multisrc/madara/Madara.kt b/lib-multisrc/madara/src/eu/kanade/tachiyomi/multisrc/madara/Madara.kt
@@ -767,12 +767,21 @@ abstract class Madara(
         return when {
             element.hasAttr("data-src") -> element.attr("abs:data-src")
             element.hasAttr("data-lazy-src") -> element.attr("abs:data-lazy-src")
-            element.hasAttr("srcset") -> element.attr("abs:srcset").substringBefore(" ")
+            element.hasAttr("srcset") -> element.attr("abs:srcset").getSrcSetImage()
             element.hasAttr("data-cfsrc") -> element.attr("abs:data-cfsrc")
             else -> element.attr("abs:src")
         }
     }
 
+    /**
+     *  Get the best image quality available from srcset
+     */
+    private fun String.getSrcSetImage(): String? {
+        return this.split(" ")
+            .filter(URL_REGEX::matches)
+            .maxOfOrNull(String::toString)
+    }
+
     /**
      * Set it to true if the source uses the new AJAX endpoint to
      * fetch the manga chapters instead of the old admin-ajax.php one.
@@ -1106,6 +1115,7 @@ abstract class Madara(
 
     companion object {
         const val URL_SEARCH_PREFIX = "slug:"
+        val URL_REGEX = """^(https?://[^\s/$.?#].[^\s]*)${'$'}""".toRegex()
     }
 }