Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync history and Sync diff don't work : Cannot read properties of null (reading 'listHistory') #12

Open
cjunekim opened this issue Aug 12, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cjunekim
Copy link

cjunekim commented Aug 12, 2022

Hello

Show Git Diff view for active file works well without an issue. However, Show Sync history for active file and Show Sync diff view for active file don't work at all showing an empty window. (BTW, I don't exactly know what they do actually)

The developer's console shows the following error:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'listHistory')
    at t.<anonymous> (app.js:1:1970557)
    at app.js:1:235078
    at Object.next (app.js:1:235183)
    at s (app.js:1:233922)

Obsidian Git version : 1.28.0
Version History Diff version : 2.0.5
Obsidian App version : 0.15.9
OS : Windows 10 21H2

@cjunekim
Copy link
Author

I am answering myself. Sync history and Sync diff seem to be related to the core plugin Sync, and if you don't use it, the result being empty is right -- however, it would be better to display some message instead, something like "Sync is not enabled" or so.

@kometenstaub
Copy link
Owner

Conditionally enabling these commands would probably make sense, yes.

@kometenstaub kometenstaub added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants