[ready] kokkos impl gemm
#197
Conversation
tpl-implementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_gemm_kk.hpp
Outdated
Show resolved
Hide resolved
tpl-implementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_gemm_kk.hpp
Outdated
Show resolved
Hide resolved
|
@mhoemmen i have updated this quite a bit, let me know what you think, when you a have a chance! I know you are busy :) |
...plementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_overwriting_gemm_kk.hpp
Outdated
Show resolved
Hide resolved
...plementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_overwriting_gemm_kk.hpp
Show resolved
Hide resolved
...plementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_overwriting_gemm_kk.hpp
Outdated
Show resolved
Hide resolved
...plementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_overwriting_gemm_kk.hpp
Show resolved
Hide resolved
tpl-implementations/include/experimental/__p1673_bits/kokkos-kernels/blas3_updating_gemm_kk.hpp
Outdated
Show resolved
Hide resolved
...mplementations/include/experimental/__p1673_bits/kokkos-kernels/mdspan_to_view_mapper_kk.hpp
Outdated
Show resolved
Hide resolved
| auto kokkos_p = to_kokkos_pointer(a.data()); | ||
| using view_type = Kokkos::View< | ||
| decltype(kokkos_p)*, | ||
| typename LayoutMapper<typename mdspan_type::layout_type>::type | ||
| decltype(kokkos_p)*, typename LayoutMapper<NestedLayout>::type |
There was a problem hiding this comment.
| decltype(kokkos_p)*, typename LayoutMapper<NestedLayout>::type | |
| std::add_pointer_t<decltype(kokkos_p)>, typename LayoutMapper<NestedLayout>::type |
(This converts, e.g., int* to int**, and const int* to const int**.)
There was a problem hiding this comment.
why is this wrong? this is for a rank-2 mdspan, so it becomes a rank-2 view
There was a problem hiding this comment.
@fnrizzi It's not wrong, just a suggestion : - )
There was a problem hiding this comment.
ok! suggestion taken!
|
@fnrizzi To clarify: It's fine to merge now, but you might like to fix the typos first. If you're in a hurry, just let me know and I'll merge it. |
|
@mhoemmen no hurry, i will fix this properly! |
| auto kokkos_p = to_kokkos_pointer(a.data()); | ||
| using view_type = Kokkos::View< | ||
| decltype(kokkos_p)*, | ||
| typename LayoutMapper<typename mdspan_type::layout_type>::type | ||
| decltype(kokkos_p)*, typename LayoutMapper<NestedLayout>::type |
There was a problem hiding this comment.
@fnrizzi It's not wrong, just a suggestion : - )
No description provided.