Add safety check for fusion #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins a reference to the thread ID
gliga
reviewed
Jul 19, 2024
| def is_safe_to_fuse(self, current: List[TracerOperation], current_views: Set[ViewType], current_safety_info: Dict[Tuple[int, int], Tuple[AccessIndex, AccessMode]], next: TracerOperation, next_views: Set[ViewType]) -> bool: | ||
| """ | ||
| Check whether the next operation is safe to fuse with the | ||
| current operations |
There was a problem hiding this comment.
this comment should document the conditions under which it would be safe to fuse
gliga
reviewed
Jul 19, 2024
| @@ -305,7 +458,7 @@ def fuse_operations(self, operations: List[TracerOperation]) -> TracerOperation: | |||
| # Avoid long names | |||
| fused_name = "_".join(names[:5]) + hashlib.md5(("".join(names)).encode()).hexdigest() | |||
|
|
|||
| return TracerOperation(None, future, fused_name, policy, workunits, operation, parsers, fused_name, args, dependencies) | |||
| return TracerOperation(None, future, fused_name, policy, workunits, operation, parsers, fused_name, args, dependencies, fused_safety_info) | |||
There was a problem hiding this comment.
some tests for the newly introduced checks?
gliga
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a safety check to prevent fusion of kernels that could introduce a dependency between threads in the fused kernel. Dependencies can only come from views, so the safety check looks at the what indices are used to access the views. Two kernels which access views only through their thread ID will not introduce a dependency between threads in the fused kernel.