Fusion: allow fusion of a single parallel_reduce with a sequence of parallel_fors #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliga
reviewed
Feb 26, 2024
| ) -> Tuple[Dict[str, Any], List[ast.arg]]: | ||
| """ | ||
| Fuse the parameters and runtime arguments of a list of workunits and rename them as necessary | ||
|
|
||
| :param workunits_trees: the list of workunit trees (ASTs) being merged | ||
| :param kwargs: the keyword arguments passed to the call | ||
| :param operation: they type of parallel operation ("parallel_for", "parallel_reduce", or "parallel_scan") |
gliga
reviewed
Feb 26, 2024
| :returns: a tuple of the fused kwargs and the combined inspected parameters | ||
| """ | ||
|
|
||
| if operation == "parallel_scan": |
There was a problem hiding this comment.
would be nice to put supported operations in an enum or just constants
gliga
reviewed
Feb 26, 2024
| @@ -140,6 +140,9 @@ def __setitem__(self, key: Union[int, TeamMember], value: Union[int, float]) -> | |||
| :param value: the new value at the index. | |||
| """ | |||
|
|
|||
| if "PK_FUSION" in os.environ: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables fusion of a single parallel_reduce that with a sequence of parallel_fors that it follows.