WIP, ENH: remainder() to API standard #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* draft the `remainder()` ufunc and turn its matching array API standad test on in the CI; many of the other changes reflect those in recent binary ufunc PRs * note that the implementation of the remainder is actually rather non-trivial here; for reference, the reviewer may want to check the following, and perhaps also the NumPy inner loop implementation: - https://stackoverflow.com/a/1907585/2942522 - https://data-apis.org/array-api/latest/API_specification/generated/array_api.remainder.html
tylerjereddy
added
enhancement
* fix up some of the `remainder()` workunits that were failing array API standard test * still needs more work though--for floating type cases I need to conform to the special cases noted here more closely: https://data-apis.org/array-api/latest/API_specification/generated/array_api.remainder.html [skip actions]
|
This one isn't ready yet--skipping the CI while I iterate on it. In particular, I think that for floating point type workunits I need to more closely obey the special cases noted at: https://data-apis.org/array-api/latest/API_specification/generated/array_api.remainder.html That is indeed quite messy so will likely take me a while. It is no wonder modulus is not recommended for floating-point types. |
tylerjereddy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft the
remainder()ufunc and turn its matching array API standad test on in the CI; many of the other changes reflect those in recent binary ufunc PRsnote that the implementation of the remainder is actually rather non-trivial here; for reference, the reviewer may want to check the following, and perhaps also the NumPy inner loop implementation: