ENH: multiply() to API std #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bring the `multiply()` ufunc up to the array API standard and turn the matching test on in the CI * similar to other recent binary ufunc PRs, with the usual drawbacks like broadcasting copies
tylerjereddy
added
enhancement
tylerjereddy
commented
Jan 17, 2023
| @@ -1,6 +1,355 @@ | |||
| import pykokkos as pk | |||
|
|
|||
|
|
|||
| @pk.workunit | |||
| def multiply_impl_1d_double(tid: int, viewA: pk.View1D[pk.double], viewB: pk.View1D[pk.double], out: pk.View1D[pk.double], ): | |||
| out[tid] = viewA[tid] * viewB[tid % viewB.extent(0)] | |||
There was a problem hiding this comment.
the modulo operator is leftover from before here--it seems harmless in local testing but should probably be removed (though it may have some merit depending on how broadcasting evolves I suppose..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring the
multiply()ufunc up to the array API standard and turn the matching test on in the CIsimilar to other recent binary ufunc PRs, with the usual drawbacks like broadcasting copies