ENH: add bitwise_and #145
Open
ENH: add bitwise_and #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
added
enhancement
* draft the `bitwise_and` ufunc and turn a subset of its array API
standard tests on in CI (this implementation does match the standard,
but we don't have "in-place bitwise_and" yet (`__iand__` seems tricky
to implement with pykokkos for some reason)
* the array API standard testing is quite thorough for this binary ufunc
so it was necessary to:
- expand the `pykokkos-base` CI builds to include up to 5 ranks
- draft broadcasting and casting infrastructure for binary ufuncs (so
that we can handle different shape/type interactions)
tylerjereddy
force-pushed
the
treddy_bitwise_and
branch
from
8e691dd
to
481da51
Compare
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Jan 5, 2023
* draft the `bitwise_or` ufunc and turn a subset of its array API standard tests on in CI * this is extremely similar to the changes in the `bitwise_and` PR at kokkosgh-145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft the
bitwise_andufunc and turn a subset of its array API standard tests on in CI (this implementation does match the standard, but we don't have "in-place bitwise_and" yet (__iand__seems tricky to implement with pykokkos for some reason)the array API standard testing is quite thorough for this binary ufunc so it was necessary to:
pykokkos-baseCI builds to include up to 5 ranks