Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KOKKOSTOOLS_LIBRARY_MODE #251

Merged

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Apr 29, 2024

KOKKOSTOOLS_LIBRARY_MODE isn't a CMake variable (and not documented) and there doesn't seem much of an advantage over using the implicit BUILD_SHARED_LIBS option. Note that kp_add_library expects all extra arguments to be source files anyway so specifying KOKKOSTOOLS_LIBRARY_MODE wouldn't actually work.

@vlkale
Copy link
Contributor

vlkale commented Apr 29, 2024

Looks OK to me especially if KOKKOSTOOLS_LIBRARY_MODE

is not doing anything anyway given what kp_add_library expects. Note that the sampler and filter are the only two utilities in Kokkos Tools, and I wonder why this was done just for Kokkos Tools.

In any case, I am good with removing it.

@vlkale vlkale added the Build Building Kokkos tools label May 31, 2024
@crtrott crtrott merged commit 0a5d81d into kokkos:develop Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Building Kokkos tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants