Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile for simple-kernel-timer and space-time-stack #241

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix Makefile for simple-kernel-timer and space-time-stack #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions profiling/simple-kernel-timer/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
CXX=g++
CXXFLAGS=-O3 -std=c++11 -g
CXXFLAGS=-O3 -std=c++17 -g
SHARED_CXXFLAGS=-shared -fPIC

all: kp_kernel_timer.so kp_reader kp_json_writer

MAKEFILE_PATH := $(subst Makefile,,$(abspath $(lastword $(MAKEFILE_LIST))))

CXXFLAGS+=-I${MAKEFILE_PATH} -I${MAKEFILE_PATH}/../../common/makefile-only -I${MAKEFILE_PATH}../all
CXXFLAGS+=-I${MAKEFILE_PATH} -I${MAKEFILE_PATH}/../../common/makefile-only -I${MAKEFILE_PATH}../all -I${MAKEFILE_PATH}../../common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now. A minor comment is that I wonder if this could be abstracted out into a make.def file to be accessed by any Kokkos Tools utility.


kp_reader: ${MAKEFILE_PATH}kp_reader.cpp kp_kernel_timer.so
$(CXX) $(CXXFLAGS) -o kp_reader ${MAKEFILE_PATH}kp_reader.cpp ${MAKEFILE_PATH}kp_shared.cpp
Expand Down
4 changes: 2 additions & 2 deletions profiling/space-time-stack/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
CXX=mpicxx
CXXFLAGS=-shared -O3 -g -fPIC -std=c++11 -Wall -Wextra
CXXFLAGS=-shared -O3 -g -fPIC -std=c++17 -Wall -Wextra

#Turn MPI support off:
#CXXFLAGS += -DUSE_MPI=0

MAKEFILE_PATH := $(subst Makefile,,$(abspath $(lastword $(MAKEFILE_LIST))))

CXXFLAGS+=-I${MAKEFILE_PATH} -I${MAKEFILE_PATH}/../../common/makefile-only -I${MAKEFILE_PATH}../all
CXXFLAGS+=-I${MAKEFILE_PATH} -I${MAKEFILE_PATH}/../../common/makefile-only -I${MAKEFILE_PATH}../all -I${MAKEFILE_PATH}../../common

kp_space_time_stack.so: ${MAKEFILE_PATH}kp_space_time_stack.cpp
$(CXX) $(CXXFLAGS) -o $@ $<
Expand Down
Loading