Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor correction to outdated folder names in build-all.sh #231

Merged

Conversation

zhangchonglin
Copy link
Contributor

I am not following this library closely, but it seems that the nvprof-connector and nvprof-focused-connector folders were renamed nvtx-connector and nvtx-focused-connector, but the build-all.sh script was not updated.

make -f $ROOT_DIR/profiling/nvprof-connector/Makefile
make -f $ROOT_DIR/profiling/nvprof-focused-connector/Makefile

@vlkale
Copy link
Contributor

vlkale commented Jan 14, 2024

@zhangchonglin Thanks! LGTM.

@crtrott @dalg24 Please check and approve when possible.

@dalg24 dalg24 merged commit daa1c9d into kokkos:develop Jan 14, 2024
5 of 7 checks passed
@zhangchonglin zhangchonglin deleted the cz/build_all_typo branch January 14, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants