Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adding rocm 5.7 support #205

Merged
merged 1 commit into from
Oct 5, 2023
Merged

ci: adding rocm 5.7 support #205

merged 1 commit into from
Oct 5, 2023

Conversation

romintomasetti
Copy link
Contributor

@romintomasetti romintomasetti commented Sep 5, 2023 •
edited
Loading

This PR adds rocm-5.7 to the pipeline.

Note that at the beginning, I tried with rocm-5.6, but got weird issues.

@romintomasetti
Copy link
Contributor Author

Hi @dalg24 I wanted to give the CI a fresh look, but it seems some nasty undetected bug appeared... Any idea?

@dalg24
Copy link
Member

dalg24 commented Sep 5, 2023

I would do a make verbose and look at the compile line. It is nonsensical, going through Cang CUDA wrappers header files.

@romintomasetti
Copy link
Contributor Author

romintomasetti commented Sep 5, 2023 •
edited
Loading

I would do a make verbose and look at the compile line. It is nonsensical, going through Cang CUDA wrappers header files.

Done in this job. I don't see any additional helping piece of info coming in...

BTW, the issue could be related to ROCm/HIP#2082.

@romintomasetti
Copy link
Contributor Author

@dalg24 It seems that with rocm-5.7 everything works!

If you agree, I would proceed with this PR 😄

masterleinad
masterleinad approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Please update the pull request title and description to reflect the most recent changes.

@romintomasetti romintomasetti changed the title ci: adding rocm 5.6 support ci: adding rocm 5.7 support Sep 26, 2023
@romintomasetti
Copy link
Contributor Author

Hi @dalg24 @masterleinad ! Would you have a second to approve and merge? Thanks!

@romintomasetti
Copy link
Contributor Author

@dalg24 It seems we still need one approval of someone with write access 😉

@romintomasetti
Copy link
Contributor Author

@vlkale Who can additionally approve this one? (with write access)

@vlkale
Copy link
Contributor

vlkale commented Oct 4, 2023

@vlkale Who can additionally approve this one? (with write access)

@crtrott or @masterleinad: Can you please look at this when possible?

@dalg24 dalg24 merged commit f37e74f into kokkos:develop Oct 5, 2023
6 checks passed
@romintomasetti romintomasetti deleted the rocm-5.6 branch October 5, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@masterleinad masterleinad masterleinad approved these changes

@vlkale vlkale vlkale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romintomasetti @dalg24 @vlkale @masterleinad