KOKKOS_TOOLS_LIBS and kp_add_example for Kernel Filter #202
Conversation
| printf( | ||
| "Checking KOKKOS_PROFILE_LIBRARY. WARNING: This is a deprecated " | ||
| "variable. Please use KOKKOS_TOOLS_LIBS.\n"); |
There was a problem hiding this comment.
Why emit this warning if KOKKOS_PROFILE_LIBRARY was not actually set?
There was a problem hiding this comment.
Yeah, agreed - this is not a great warning text. It was copied and pasted from another library (nvtx-connector). The text after "WARNING: .." should be printed only in the case that KOKKOS_PROFILE_LIBRARY was set. I will change.
Emit KOKKOS_PROFILE_LIBRARY environment variable warning print only if not set rather than printing whenever KOKKOS_TOOLS_LIBS is not found.
| @@ -182,7 +196,7 @@ extern "C" void kokkosp_init_library(const int loadSeq, | |||
|
|
|||
| printf("============================================================\n"); | |||
| } | |||
| } | |||
| } // end kokkosp_init_library | |||
There was a problem hiding this comment.
I don't really the point of marking the closing brace here.
| printf("KokkosP: Found that KOKKOS_PROFILE_LIBRARY is set and it will be used.\n"); | ||
| printf("KokkosP: Note that KOKKOS_PROFILE_LIBRARY is a deprecated variable. " | ||
| "Please use KOKKOS_TOOLS_LIBS in the future.\n"); | ||
| } // end check for backward compatability |
There was a problem hiding this comment.
Typo compat(i)bility. I don't see the point of the comment. It is not even the right place. You are missing a cling brace I don;'t even think this compiles
There was a problem hiding this comment.
Thanks. I messed it up (in the process of trying to put that comment). See updated version .
|
Note that this PR doesn't use the namespace for KokkosTools and Filter and kp_kernel_filter.cpp has functions with extern "C" . This will be fixed in a separate PR. |
Kernel filter is used for nvtx_focused_connector and other tools. It is outdated given changes in user interface and cmake build systems.
This PR is associated with #176 .
This PR does the following: