Programatically filter out tool-induced fences from the sampler tool utility #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tool-invoked_fence function. Note that fence function is is doing global fencing, and that the end_parallel_* will need a devID if doing per-device fencing in the future.
…device ID for fence (which could be obtained through the space handle).
…device ID for fence (which could be obtained through the space handle). Fixing with formatting.
…terface function. Still need to get device ID for fence (which could be obtained through the space handle). Fixing with formatting.
vlkale
changed the title
vlkale
changed the title
|
This is a example run and output on MacBook using g++ (default) and Kokkos serial host backend for stream, without and with Kokkos Tools global fencing. Kokkos Tools Global Fence turned off (no auto-fencing)Kokkos Tools Global Fence (auto-fencing) on |
masterleinad
requested changes
Jul 20, 2023
Comment on lines
10
to
11
| // using Kokkos::Tools::Experimental; | ||
| // using mytpi_type = Kokkos::Tools::Experimental::ToolProgrammingInterface; |
There was a problem hiding this comment.
Remove all commented lines you are not using.
| @@ -82,9 +125,7 @@ void kokkosp_init_library(const int loadSeq, const uint64_t interfaceVer, | |||
| printf("KokkosP: Next library to call: %s\n", nextLibrary); | |||
| printf("KokkosP: Loading child library ..\n"); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
What's up with all these whitespace changes?
There was a problem hiding this comment.
I will fix, making sure the code file is indeed getting processed through clang-format.
There was a problem hiding this comment.
@masterleinad Does the new file committed address the issues you have with whitespace changes?
Can you please summarize and interpret the results? |
Co-authored-by: Daniel Arndt <[email protected]>
@masterleinad The result shows output of the test of the proposed new sampler with optimization to fencing, in the case that global fencing is on (KOKKOS_TOOLS_GLOBALFENCES=1) and the case that global fences is off (KOKKOS_TOOLS_GLOBALFENCES=0). The output shows that given the sampling skip rate is 105, only 46 kernel invocations out of the 1000 have a Kokkos Tool child event for the Kokkos Tools connector specified (here simple-kernel-timer) dispatched. One can intrepret this as the sampler behaving correctly, in both cases. Perhaps a better test case here is the output from the version of the sampler in Kokkos Tools |
Removing all commented code (which is no longer needed) as requested.
|
For reference, here is an output of a build and compilation on a MacBook Pro (2.9 GHz Quad-Core Intel Core i7) |
|
I am aware of the build test with Kokkos that's in the CI that is failing. I don't know if that is the reason for the problem. I am putting this back into a draft PR to figure things out from my end. |
Note that the device identifier used in the |
|
@masterleinad Thanks for that. I will take a look at that part of the interface. |
More with hashmap and nestedID coming
vlkale
added a commit
to vlkale/kokkos-tools
that referenced
this pull request
Aug 5, 2023
mistakenly made this change in this PR but it is part of PR kokkos#194
…track of nested (child) kernel ID on sample.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #179.